Document domain points determinism in DKG instances #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 78.28% 79.96% +1.67%
==========================================
Files 24 24
Lines 5066 5914 +848
==========================================
+ Hits 3966 4729 +763
- Misses 1100 1185 +85 ☔ View full report in Codecov by Sentry. |
piotr-roslaniec
force-pushed
the
domain_points
branch
from
34add7d
to
66bdd57
Compare
piotr-roslaniec
changed the title
piotr-roslaniec
force-pushed
the
domain_points
branch
from
66bdd57
to
2161c1c
Compare
piotr-roslaniec
force-pushed
the
domain_points
branch
2 times, most recently
from
5705ec1
to
aed5673
Compare
|
This test demonstrates that we'll have to deal with an existing restriction on domain set selection that implies that node replacement has to be implemented using domain point reuse, or in other words, not by assigning new domain points. See the plan laid out in #160 (comment) |
piotr-roslaniec
force-pushed
the
domain_points
branch
from
81b7b79
to
9aca6ae
Compare
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
validators_numparameter of the DKG.validators_numis rounded up to the nearest power of two. So as long as ourvalidators_numis rounded to the same domain size size asvalidators_numof a different DKG instance, our domain points are the same.Issues fixed/closed:
Why it's needed:
Notes for reviewers: